-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiedit e2e tests #4464
Multiedit e2e tests #4464
Conversation
…' into playwright-tests
import {restoreDatabaseSnapshot, s} from './utils'; | ||
|
||
test.describe('Multiedit', async () => { | ||
test('Can open article in multiedit', async ({page}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to test only opening. The main test should be opening 2 items(it is MULTI edit after all), changing a field, like headline, saving both, closing multi edit and seeing if changes persisted. If opening items in multi edit mode didn't work, the main test wouldn't pass either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix tests first and then I take a look
import {restoreDatabaseSnapshot, s} from './utils'; | ||
|
||
test.describe('Multiedit', async () => { | ||
test('Can edit articles in multiedit', async ({page}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test names.
await page.locator(s('multiedit-screen', 'multiedit-article=story 2')).hover(); | ||
await page | ||
.locator(s('multiedit-screen', 'multiedit-article=story 2')) | ||
.getByRole('button', {name: 'save'}) | ||
.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you create multi-edit helpers file and extract saving there?
This reverts commit 8e04663.
SDESK-7164